Windows & X11: Window::set_resizable #558

dannyfritz · 2018-06-07T21:18:33Z

Tested on all platforms changed (Mutter, Windows 10)
Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created an example program if it would help users understand this functionality

Related to #540

francesca64 · 2018-06-07T22:11:16Z

More architecting might be in order for this PR. Currently, the max and min resize dimensions are lost when toggling resizable and not.

Gah, I was looking forward to nagging you about needing to handle that, but it seems you already knew. The line I'd prepared was about how the fact that this sets the min/max size should be an implementation detail that's encapsulated by the API.

That state should be stored in SharedState, and it's of the utmost importance that I remember to DPI-adjust all of this when I rebase #548.

I did expose the method through the wrapper Window class

If I were you, I'd do all of this in one PR, or just take the approach I used in #553 and don't add the top-level Window method yet. Android, iOS, and Emscripten are just supposed to have "N/A" stubs, so getting CI to pass is easy, though any platforms where it is applicable should have unimplemented! stubs instead.

Since this seems to be mostly complete, I'm not against including it in 0.15.1, though it also doesn't really matter, since 0.16.0 will be released quite soon afterwards (I just want to get some regression fixes out instead of gating them behind an API migration).

francesca64 · 2018-06-07T22:12:15Z

CHANGELOG.md

@@ -3,6 +3,7 @@
 - On X11, the `Moved` event is no longer sent when the window is resized without changing position.
 - `MouseCursor` and `CursorState` now implement `Default`.
 - `WindowBuilder::with_resizable` implemented for Windows, X11, and macOS.
+- `Window::set_resizable` implemented for MacOS, X11, and Windows.


The correct stylization is "macOS", and it also reads a little easier if you use the same ordering as in the previous line.

francesca64 · 2018-06-07T22:16:49Z

examples/resizable.rs

+            }
+            _ => winit::ControlFlow::Continue,
+        },
+        _ => winit::ControlFlow::Continue,


As an official winit example™, it would be good if you refactored this to not repeat winit::ControlFlow::Continue, i.e. https://github.com/tomaka/winit/blob/master/examples/handling_close.rs

francesca64 · 2018-06-07T22:23:36Z

src/lib.rs

@@ -422,7 +422,7 @@ pub struct WindowAttributes {
    /// The default is `None`.
    pub max_dimensions: Option<(u32, u32)>,

-    /// [Windows & X11 only] Whether the window is resizable or not
+    /// [Windows, MacOS, and X11 only] Whether the window is resizable or not


It looks like you followed the precedent set by [iOS only], but you should know two things about that:

The [iOS only] doc comment isn't accurate anymore...

That was added a long time ago, and back before winit had someone barking about style, so it's not necessarily something you should replicate. Sticking to the conventions established in other areas of the documentation is probably better.

francesca64 · 2018-06-07T22:26:28Z

src/platform/linux/mod.rs

+        match self {
+            &Window::X(ref w) => w.set_resizable(resizable),
+            // &Window::Wayland(ref w) => w.set_resizable(resizable),
+            _ => {}


We tend to favor _ => (), but more importantly, it's more appropriate to stub this as unimplemented!(), by decree of tomaka.

The idea is that it makes people more likely to fix it... in my experience, all it does is make people more likely to yell at us, though that does make me more likely to fix it.

I've released version 0.2.2 of smithay-client-toolkit which adds a set_resizable method to its Window type, that does what we need for wayland support. So, fixing should be pretty trivial, I can do this once this is merged, as soon as I secure the 5 minutes it'll take.

francesca64 · 2018-06-07T22:30:56Z

src/platform/linux/x11/window.rs

+        unsafe {
+            self.update_normal_hints(|size_hints| {
+                if resizable {
+                    (*size_hints).flags &= !ffi::PMinSize;


You can cut the number of flag changes in half in this function.

francesca64 · 2018-06-07T22:34:11Z

src/platform/windows/window.rs

+                winuser::GetWindowLongW(self.window.0, winuser::GWL_STYLE)
+            };
+            if resizable {
+                style |= winuser::WS_SIZEBOX as i32;


I'd prefer you use the winapi LONG type instead of i32.

francesca64 · 2018-06-07T22:35:35Z

src/platform/windows/window.rs

+            if resizable {
+                style |= winuser::WS_SIZEBOX as i32;
+            } else {
+                style &= !winuser::WS_SIZEBOX as i32;


What's the precedence here?

The precedence for removing the WS_SIZEBOX when setting resizable to false? I guess I'm not 100% sure what you are referring to.

Oh lol. The precedence is LONG.

Yeah, I just wanted to make sure it was zero-extending before flipping the bits. Or rather, I wanted to make sure you thought about that.

francesca64 · 2018-06-07T22:38:27Z

src/platform/windows/window.rs

@@ -239,6 +239,33 @@ impl Window {
            }
        }
    }
+
+    /// See the docs in the crate root file.


You don't need to add this comment, since #548 completely removes them... they don't seem to be at all helpful, especially since these are doc comments on private methods.

More importantly, what happens when you use this method while the window is fullscreen?

dannyfritz · 2018-06-08T21:33:59Z

I addressed style changes and X11 remembering the window min/max size. I haven't addressed or tested setting resizable while in fullscreen.

francesca64 · 2018-06-09T00:04:44Z

src/window.rs

+    /// ## Platform-specific
+    ///
+    /// This only has an effect on Windows, X11, and macOS.
+    */


You left the block comment open/close in.

Heh, good catch. I'm not sure I would have ever seen that as a code reviewer.

francesca64 · 2018-06-09T00:28:10Z

For whatever reason, set_resizable(true) doesn't work on Xfwm4. The hints show up as expected in xprop, and it worked when I tried it in KWin and Openbox... I'll see if I can figure out a workaround, but I'll merge this even if I can't find a solution. There are some things that are simply beyond our power.

francesca64 · 2018-06-09T00:49:51Z

This description doesn't seem entirely accurate; from what I'm seeing Xfwm stops picking up on changes whenever min/max are set to values that make it unresizable (even when after mapping): https://mail.xfce.org/pipermail/xfce/2015-August/034641.html

Note that my phrasing of "values that make it unresizable" rather than "the same value" was deliberate; I tried to outsmart it by adding 1 to the min size and subtracting 1 from the max size, but the problem was still present. (It would've been a bad hack to use anyway, since I'm sure there are some things that become quite unhappy if min>max.)

So, once logging is added, I'll just add a warn! if it's being used on Xfwm4. Besides that, I just need to check that this works as expected on Windows, and we'll be good to go.

francesca64 · 2018-06-09T01:43:15Z

As predicted, things on Windows don't quite work right with fullscreen mode. Creating a window with_resizable(false), and then calling set_resizable(true) after entering fullscreen results in the following:

The window is "snapped out" of fullscreen, but still approximately the fullscreen size
The window is, at that point, resizable
Exiting fullscreen restores the original size, but the window isn't resizable
Calling set_resizable(true) again does not make the window resizable
It can only be made resizable again by calling set_resizable(false) before calling set_resizable(true)

There don't seem to be any other problems, though.

francesca64 · 2018-06-11T15:15:42Z

So, the situation with Xfwm is worse than I thought, since it completely breaks the DPI scaling that will be introduced in #548.

I think the simplest thing to do is to just have these methods no-op if you're running Xfwm. While it's not the most elegant thing, the only alternative is to add a scary notice to the docs and expose EventsLoopExt::get_wm_name, and I'm quite confident that only something like 1/16th of people would actually follow that proviso. Since Xfwm is my main WM, that's not a risk I'm willing to take.

I'll add that check myself, it's just I want to make sure there's agreement that it's reasonable. I'd also like to add some documentation stating that using these methods doesn't exempt one from handling Resized, since that event can still be triggered via DPI scaling, fullscreen mode, etc.

dannyfritz · 2018-06-11T18:03:17Z

So I made it so it can go fullscreen and change the resizability of the restored window on Windows. I'm not particularly fond of the duplication of function in the restore function though. But it does seem to work as I would expect when swapping fullscreen and resizability.

I'll mention that when going from window to fullscreen and back to window, min and max window sizes are forgotten.

francesca64 · 2018-06-11T19:03:16Z

I'll mention that when going from window to fullscreen and back to window, min and max window sizes are forgotten.

I'm guessing it already had that problem (this isn't a regression)?

dannyfritz · 2018-06-11T19:57:20Z

Oh, actually, it turns out I removed the min/max from my example and forgot it. So it is definitely remembering the min/max of the window. https://gist.github.com/dannyfritz/6eb8e7718b1cb3871e11fdefa32d0a14

But... the fullscreen is... interesting. It only gets to the size of the max dimensions.

dannyfritz · 2018-06-11T20:22:54Z

And testing the example without resizable code on master confirms it is not a regression. I don't see an issue for it in the issue tracker if this is indeed unintended.

francesca64 · 2018-06-11T21:17:02Z

It only gets to the size of the max dimensions.

What's supposed to happen here isn't well-defined, which is to say, no one's actually thought about it much. Though, I think we probably all expect setting a window to fullscreen to set it to fullscreen, so that should probably take precedence over the max size.

Maybe I'll remember to fix that when I rebase #548, since that also adds logic for determining when the window is entering fullscreen.

Anyway, thanks for all the work on this! We should be good to merge now, right after I make the changes I mentioned.

dannyfritz · 2018-06-11T21:23:10Z

That's great to hear. 😄

You have been both very knowledgeable and helpful throughout the process.

francesca64 · 2018-06-11T22:47:37Z

Aw, thanks so much!

dannyfritz added 2 commits June 7, 2018 14:28

Windows: Window::set_resizable

da3bd4d

X11: Window::set_resizable

1933165

dannyfritz mentioned this pull request Jun 7, 2018

with_resizable / set_resizable #540

Closed

francesca64 reviewed Jun 7, 2018

View reviewed changes

dannyfritz changed the title ~~X11: Window::set_resizable~~ Windows & X11: Window::set_resizable Jun 8, 2018

dannyfritz mentioned this pull request Jun 8, 2018

Windows: Window::set_resizable #557

Closed

4 tasks

dannyfritz force-pushed the set_resizable-x11 branch from cbeaa71 to 4b280ef Compare June 8, 2018 20:43

Code style regarding resizable

dd1022a

dannyfritz force-pushed the set_resizable-x11 branch from 4b280ef to dd1022a Compare June 8, 2018 20:47

X11: set_resizable remember max/min window size

7351b4c

Stub out set_resizable on Android, iOS, and emscripten

eff0012

francesca64 reviewed Jun 9, 2018

View reviewed changes

francesca64 added DS - windows DS - x11 labels Jun 9, 2018

remove comment block from docs

ebc930c

Windows: set_resizable in fullscreen

098ad70

francesca64 added 2 commits June 11, 2018 17:43

Special case Xfwm

13978a8

Added fun provisos to docs

3195c2a

francesca64 merged commit be5a2b0 into rust-windowing:master Jun 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows & X11: Window::set_resizable #558

Windows & X11: Window::set_resizable #558

dannyfritz commented Jun 7, 2018 •

edited

Loading

francesca64 commented Jun 7, 2018

francesca64 Jun 7, 2018

francesca64 Jun 7, 2018

francesca64 Jun 7, 2018

francesca64 Jun 7, 2018

elinorbgr Jun 8, 2018 •

edited

Loading

francesca64 Jun 7, 2018

francesca64 Jun 7, 2018

francesca64 Jun 7, 2018

dannyfritz Jun 8, 2018

dannyfritz Jun 8, 2018

francesca64 Jun 9, 2018

francesca64 Jun 7, 2018

dannyfritz commented Jun 8, 2018

francesca64 Jun 9, 2018

dannyfritz Jun 9, 2018

francesca64 commented Jun 9, 2018

francesca64 commented Jun 9, 2018 •

edited

Loading

francesca64 commented Jun 9, 2018

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018 •

edited

Loading

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018 •

edited

Loading

dannyfritz commented Jun 11, 2018

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018

francesca64 commented Jun 11, 2018

Windows & X11: Window::set_resizable #558

Windows & X11: Window::set_resizable #558

Conversation

dannyfritz commented Jun 7, 2018 • edited Loading

francesca64 commented Jun 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elinorbgr Jun 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dannyfritz commented Jun 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesca64 commented Jun 9, 2018

francesca64 commented Jun 9, 2018 • edited Loading

francesca64 commented Jun 9, 2018

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018 • edited Loading

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018 • edited Loading

dannyfritz commented Jun 11, 2018

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 11, 2018

francesca64 commented Jun 11, 2018

dannyfritz commented Jun 7, 2018 •

edited

Loading

elinorbgr Jun 8, 2018 •

edited

Loading

francesca64 commented Jun 9, 2018 •

edited

Loading

dannyfritz commented Jun 11, 2018 •

edited

Loading

dannyfritz commented Jun 11, 2018 •

edited

Loading